Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3D12: Transition compute textures to UAV state #10020

Merged
merged 1 commit into from Aug 11, 2021

Conversation

K0bin
Copy link
Contributor

@K0bin K0bin commented Aug 11, 2021

When doing GPU texture decoding Dolphin never transitions the decoding texture to RESOURCE_STATE_UNORDERED_ACCESS despite writing to it in a compute shader. It gets created with RESOURCE_STATE_PIXEL_SHADER_RESOURCE so there isn't any implicit state promotion going on either.

This could fix https://bugs.dolphin-emu.org/issues/12094. I can't reproduce that bug though, it seems to only affect AMD GPUs.
Nvidia GPUs ignore the VkImageLayout with Vulkan so the reason for why it works on Nvidia might be something similar.

@Tilka
Copy link
Member

Tilka commented Aug 11, 2021

Confirmed that it fixes the bug.

@Tilka Tilka merged commit a27dbe5 into dolphin-emu:master Aug 11, 2021
11 checks passed
@K0bin K0bin deleted the d3d12-state-fix branch August 12, 2021 07:38
@K0bin
Copy link
Contributor Author

K0bin commented Aug 12, 2021

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants