Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Add entitlement to allow debugger to attach in Debug builds #10022

Merged
merged 1 commit into from Aug 13, 2021

Conversation

merryhime
Copy link
Contributor

In order to attach a debugger to a process with a Hardened Runtime (e.g. on an M1 mac), one needs the com.apple.security.get-task-allow entitlement.

Normally this entitlement is injected by XCode when running from XCode (assuming the XCode attribute CODE_SIGN_INJECT_BASE_ENTITLEMENTS is enabled), but this doesn't happen when building from a makefile or when you manually specify entitlements directly to codesign like this.

@JosJuice
Copy link
Member

Is there a reason why we don't want to allow this for release builds too?

@Tilka
Copy link
Member

Tilka commented Aug 12, 2021

Debug features might make exploits easier and are probably disabled by default for a reason. Dolphin isn't exactly trying hard to be secure when running untrusted code but no need to add more weak points.

@lioncash lioncash merged commit c43f451 into dolphin-emu:master Aug 13, 2021
11 checks passed
@merryhime merryhime deleted the codesign-debug branch August 13, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants