DolphinQt: Minor consistency fixes for the Settings window

[mbc07]

During the (ongoing) review of the Brazilian Portuguese translation, I noticed various minor consistency issues with the main Settings window, and this PR fixes all of them. Here's a breakdown of what changed (with screenshots):

General tab

• Fixed Fallback region dropdown list misalignment in comparison to the other dropdown lists from this tab

  Before

  

  After

  

Audio tab

• Fixed inconsistent usage of the ms and percent units (e.g. 20ms and 100 % instead of 20 ms and 100%)

• Removed ms abbreviation from the latency tooltip, to make it consistent with the buffer size tooltip where it's not abbreviated

  Before

  

  After

  

GameCube tab

• Made the dropdown lists use all available horizontal space, making them consistent with the dropdown lists of other Dolphin tabs/windows using similar single column layouts

• Reworded the Skip Main Menu tooltip from "Put Main Menu roms in User/GC/{region}." to "Put IPL ROMs in User/GC/<region>." (not shown in the screenshot)

  Before

  

  After

  

Broadband Adapter settings dialog

The bulk of this PR is there. Initial goal was to just hide the useless help button from the window title and to make the XLink Kai URL clickable. This dialog was previously implemented with a simple QInputDialog::getText function call, but it couldn't achieve the clickable URL with that since the dialog generated by the function is very simple and not much customizable, so I had to implement a new one from scratch.

Since I had already got my hands dirty at this point, I also implemented input validation for the MAC address (didn't add any for the XLink Kai address since you apparently can use URLs instead of just IP addresses -- didn't test that, though). Also, both BBA types now has a clickable URL, XLink Kai adapters point to the URL that was already there on master, while TAP-based adapters now point to the relevant Dolphin Wiki page. Oh, the window titles were also reworded as the previous ones were too big to be fully displayed.

Before (TAP Adapter)

After (TAP Adapter)

Input validation error (new)

Before (XLink Kai)

After (XLink Kai)

Wii tab

• Changed "Wii Remote Rumble" to "Enable Rumble". All other checkboxes from this tab and most checkboxes from other Dolphin windows are worded like <action> <something> (enable this, use that, allow something, etc.), this checkbox didn't follow that. Plus, it's now consistent with the same checkbox found in the GC Adapter for Wii U settings dialog.

  Before

  

  After

  

USB Whitelist dialog

• Made all validation popups use the same window title and same alert type. It was a bit strange and inconsistent having a warning type popup named "USB Whitelist Error"

  Before

  

  After

  

Advanced tab

• Made the CPU Emulation Engine dropdown use all available horizontal space, making it consistent with the dropdown lists of other Dolphin tabs/windows using similar single column layouts

• Fixed inconsistent usage of the MB and percent units (e.g. 24MB and 100 % instead of 24 MB and 100%)

  Before

  

  After

  

---

And that's it. For whoever reviews this, please double check the new BroadbandAdapterSettingsDialog.cpp/.h files, I read the contributing guide twice but I'm still not sure if I've missed something...

[mbc07]

Just pushed a small fix. On a fresh install, the BBA Address will be empty until you launch a game, and there wasn't any indication of the MAC address format expected, which could result in some validation popups screaming at you until you figured out the expected format. To address that, I've added placeholders to the input field:

[Dentomologist]

There's not much information on that page. I think we should link to https://www.teamxlink.co.uk/wiki/Dolphin_Gamecube_XLink_BBA_Tutorial instead.

[mbc07]

That's an external website, not controlled by us. I would rather keep linking to the current URL, which is generic, than to link directly to a specific page which can be moved or renamed anytime...

[mbc07]

Ping