VolumeVerifier: Use correct IOS filename for development discs. #10028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Aug 14, 2021
GerbilSoft
force-pushed
the
bugfix/RVT-firmware-filenames
branch
from
ed93a76
to
f026405
Compare
|
I don't have any development discs to verify this with, but I'll trust you that this is correct. However you'll need to fix the lint error before this can be merged. |
Retail-signed discs use the format: IOS56-64-v5661.wad Debug-signed discs use the format: firmware.64.56.22.29.wad Debug-signed discs usually have a 128 version of the firmware as well, since some devkits have 128 MB MEM2. (Retail has 64 MB.)
GerbilSoft
force-pushed
the
bugfix/RVT-firmware-filenames
branch
from
f026405
to
95d3416
Compare
|
Updated to switch to u64 and fix the lint error. I have several RVT-R images, all of which have WADs in the update partition similar to the following: These are both the same IOS version (equivalent to retail IOS56 v5405). The 64 version is for systems with 64 MB MEM2 (RVT-R Reader), while the 128 version is for systems with 128 MB MEM2 (RVT-H Reader, NDEV). |
JosJuice
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Retail-signed discs use the format: IOS56-64-v5661.wad
Debug-signed discs use the format: firmware.64.56.22.29.wad
Debug-signed discs usually have a 128 version of the firmware as well, since some devkits have 128 MB MEM2. (Retail has 64 MB.)
This fixes part of VolumeVerifier for debug discs. It's not validating the signatures properly. I attempted to add the debug root key (which is different from retail), and that helped, but ESDevice::VerifyContainer() was still getting an error from mbedtls, even though the public key appeared to be correctl