DSPInterpreter: Fix IsLess #10031
Merged
DSPInterpreter: Fix IsLess #10031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phire
approved these changes
Aug 16, 2021
|
The commit message itself should probably contain the PR description (difference images aren't necessary though), so that the context of what's being fixed is more obvious (and stores that info directly in the repository). LGTM otherwise though. |
`IsLess` would incorrectly return true if both `SR_OVERFLOW` and `SR_SIGN` are set, as `(sr & SR_OVERFLOW) != (sr & SR_SIGN)` becomes `SR_OVERFLOW != SR_SIGN` which is true as the two masks are different. This broke in e651592. This issue only affected the DSP LLE Interpreter, and not the DSP LLE JIT. I've also included a simple test case for this. `ax0.l` (on the top left) is set to 0 if the instruction following `IFL` does not execute and to 1 if it is executed.
Pokechu22
force-pushed
the
dsp-int-less
branch
from
ac12e2d
to
14119c8
Compare
lioncash
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
IsLesswould incorrectly return true if bothSR_OVERFLOWandSR_SIGNare set, as(sr & SR_OVERFLOW) != (sr & SR_SIGN)becomesSR_OVERFLOW != SR_SIGNwhich is true as the two masks are different. This broke in e651592.This issue only affected the DSP LLE Interpreter, and not the DSP LLE JIT.
I've also included a simple test case for this.
ax0.l(on the top left) is set to 0 if the instruction followingIFLdoes not execute and to 1 if it is executed.On console
On Dolphin with JIT
On Dolphin before this change
On Dolphin with this change