Interpreter: Simplify mcrfs implementation #10040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
simplify-mcrfs
branch
from
009e0eb
to
b88e929
Compare
BhaaLseN
reviewed
Aug 18, 2021
Source/Core/Core/PowerPC/Interpreter/Interpreter_SystemRegisters.cpp
Outdated
Show resolved
Hide resolved
JosJuice
force-pushed
the
simplify-mcrfs
branch
from
b88e929
to
4f09c32
Compare
leoetlino
reviewed
Aug 30, 2021
| const u32 fpflags = (FPSCR.Hex >> shift) & 0xF; | ||
|
|
||
| // If any exception bits were read, clear them | ||
| FPSCR.Hex &= ~((0xF << shift) & (FPSCR_FX | FPSCR_ANY_X)); |
There was a problem hiding this comment.
Could you explain why the mask is AND'd with FPSCR_FX | FPSCR_ANY_X?
There was a problem hiding this comment.
If we read a bit that represents whether a certain exception has happened, we need to clear that bit. But if we read some other bit, like the rounding mode, FPSCR, or whether a certain exception should be enabled, that bit shouldn't be cleared.
leoetlino
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.