Interpreter: Make signedness and narrowing conversions explicit #10041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Aug 18, 2021
It might theoretically be useful, but only if someone decides to make major changes to dolphin's JITs in the future. Not sure if it's worth keeping around just for that eventuality. Though, any removal should be done in another PR after merging this one. |
Makes our conversions between the different signs explicit to indicate that they're intentional and also silences compiler warnings when compiling with sign conversion or stricter truncation warnings enabled.
BhaaLseN
reviewed
Aug 18, 2021
leoetlino
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lioncash)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Makes our conversions between different signs and cases where truncations would occur to be explicit to indicate that they're intentional and, well, make implicit conversions explicit for reading purposes, which I think is preferable for the interpreter, given it essentially partially doubles as a reading reference for faster CPU backends to base behavior off of in tandem with other documenation. This also resolves numerous compiler warnings when stricter conversion warnings are enabled.
Note that we have a bunch of seemingly... old history tracing code in Interpreter.cpp, if this isn't particularly useful, I'm fine with completely removing it, since it'd make the interpreter's Run() member function a little more compact and nicer to read without the ifdefs.