Raise program exception on floating point exceptions #10043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess I should note that this doesn't work yet. |
Sintendo
suggested changes
Aug 19, 2021
JosJuice
force-pushed
the
true-crime
branch
2 times, most recently
from
c8ec427
to
7170219
Compare
BhaaLseN
reviewed
Aug 29, 2021
|
While it was painfully slow, enabling the floating point exceptions for Call of Duty: Finest Hour also fixed the crash there, but playing through that game with it on might be worse than it crashing. Actually, playing the game at all is worse than it crashing. |
|
JMC has confirmed on IRC that both of the affected games are fixed by just handling divide by zero exceptions (like the game INI commit enables). |
JMC47
approved these changes
Sep 7, 2021
JosJuice
force-pushed
the
true-crime
branch
from
0f1b4d3
to
70f83e8
Compare
|
I'm putting a final call out for this. It will get merged if no one is going to review it. True Crime must be unleashed on the masses. |
The next commit will make the interpreter run this after every float instruction, so I think a little optimization here is justified.
This is needed not only for the next commit, but also for correctly emulating float instructions that write to CR1.
This is done entirely through interpreter fallbacks. It would probably be possible to implement this using host exception handlers instead, but I think it would be a lot of complexity for a rarely used feature, so let's not do it for now. For performance reasons, there are two settings for this feature: One setting which does enables just what True Crime: New York City needs and one setting which enables it all. The latter makes almost all float instructions fall back to the interpreter.
Combined with the previous commits in this pull request, this fixes https://bugs.dolphin-emu.org/issues/7230 (True Crime: New York City) and https://bugs.dolphin-emu.org/issues/9650 (Call of Duty: Finest Hour).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes https://bugs.dolphin-emu.org/issues/7230 (True Crime: New York City) and https://bugs.dolphin-emu.org/issues/9650 (Call of Duty: Finest Hour).