DolphinQt: Remove Windows dialog help buttons #10047
Merged
+37
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentomologist
commented
Aug 21, 2021
| QInputDialog::getText(this, tr("Input"), tr("Enter address to watch:"), QLineEdit::Normal, | ||
| QString{}, nullptr, Qt::WindowCloseButtonHint); |
There was a problem hiding this comment.
The first three new parameters are just default arguments.
Qt::WindowCloseButtonHint overrides the Qt::WindowFlags parameter with the only bit we want set, clearing the offending Qt::WindowContextHelpButtonHint.
iwubcode
approved these changes
Aug 22, 2021
|
|
lioncash
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Removes the Windows help button from a handful of dialogs. I left the XLinkKai and Ethernet dialogs alone because they're taken care of in #10025.
Also throws a few consts around.
Fixes https://bugs.dolphin-emu.org/issues/11536.
As noted in that report there's an option to globally disable the help button, but that would require us to bump the minimum Qt version from 5.9 to 5.10. Once we do bump the version we'll want to go through and remove all the hints.