Revert "DSPJit: Sign-extend acS.h to 32 bits" #10051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This reverts commit dc2eab1. That commit broke the DSP recompiler for most games (causing a large number of unknown pointer errors), similar to what happened with the DSP interpreter before bug 12633 was fixed (by a different change in #10045).
I'm not entirely sure why this commit causes issues. It may be something to do with multiple registers being stored in one host register, and thus the 32-bit operation causing one to be clobbered, but I'm not certain of this. Reverting it for now seems to be the best choice, especially as
cond_testhas the same results with it reverted so it doesn't seem to actually make much of a difference.