IOS/Network/KD: Minor tidy-up changes #10053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make use of std::array - Move helper functions inside it as lambdas - Eliminate sign-conversions that were occurring (promotion of u8 to int)
These functions don't touch any class state, so they can be turned into internal helper functions. While we're at it, we can move the enumerations as well.
Makes it a distinct type instead of decaying to an ambiguous u8.
BhaaLseN
approved these changes
Aug 24, 2021
…f maps Currently we were using heap allocating maps that last for the entire duration of the emulator running. Given the size N of both of these maps are very small (< 20 elements), we can just make use of an array of pairs and perform linear scans. This is also fine, given this code isn't particularly "hot" either, so this won't be run often.
Makes the enum strongly typed instead of interacting with a raw u32 value. While we're at it, we can add helpers to the NWC24Config to make using code poke at the internals of the class a little bit less and also make the querying a little nicer to read.
… class These are only used internally and not intended to be used outside of the class itself.
According to WiiBrew this is a version number (thanks to Awesomebing1 for documenting this!)
These are only ever used here, so they can be turned into an internal implementation detail.
Silences compiler warnings and also makes the conversions here explicit to the reader.
leoetlino
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, 3 of 3 files at r7, 1 of 1 files at r8, 2 of 2 files at r9, 2 of 2 files at r10, 1 of 1 files at r11, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lioncash)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Initially this was only intended to change the maps in NetKDRequest's getter functions, but snowballed into this overall set of changes as possible improvements were noticed.
Each commit is relatively self-isolated from the surrounding changes to make for ease of piece-by-piece review.