Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JitArm64: Codegen space reuse #10055

Merged
merged 3 commits into from Nov 20, 2021
Merged

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Aug 24, 2021

JitArm64 port of PR #8765. Fixes https://bugs.dolphin-emu.org/issues/11717.

@JosJuice
Copy link
Member Author

I have tested that this works when playing games a short while, but not that it works when playing games for the length of time that would be needed to trigger a cache clear. @JMC47, would you like to test?

Reusing the slowmem handlers of existing blocks meshes badly
with reusing the empty space left when destroying blocks.
I don't think reusing slowmem handlers was much of a gain anyway.
@JMC47 JMC47 merged commit e5a4a86 into dolphin-emu:master Nov 20, 2021
10 checks passed
@JosJuice JosJuice deleted the jitarm64-reuse-memory branch November 20, 2021 22:36
@brujo5
Copy link

brujo5 commented Nov 27, 2021

From 5.0-15524 "JitArm64: Codegen space reuse" the games stutter all the time and become unplayable on android, tested with prince of persia forgotten sands and others. All versions before this one work perfectly that I have tried it several times. Thx.

Tested with SD860 Android 11

@DatEmulationGuy
Copy link

DatEmulationGuy commented Dec 6, 2021

Same chip as @brujo and I found that F1 2002 will stutter like crazy in 15524 and probably every build after it. Game ran very good in many older builds on the same chip

@JMC47
Copy link
Contributor

JMC47 commented Dec 7, 2021

I was messing with this, it looks like some bug is causing the game to repeatedly clear the code-cache. This will probably be fine once we figure out why that's happening.

@Bellicosei
Copy link

Same issue still seems to be occurring on Harry Potter PoA, on Dolphin 5.0-15586

@JMC47
Copy link
Contributor

JMC47 commented Dec 7, 2021

We need to bisect within the commits, but compiling is being annoying.

@JosJuice
Copy link
Member Author

JosJuice commented Dec 8, 2021

@brujo5, @DatEmulationGuy, @jlagaman: Please test PR #10267.

@brujo5
Copy link

brujo5 commented Dec 9, 2021

@JosJuice It work perfect as before.Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants