DolphinQt: Minor localization changes #10056
Merged
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows translators to specify different translations if the target languages have pluralization rules that differ from English.
Gives the translator full control over the string's localization instead of only one part of it.
Makes the context menu selections consistent with the rest of the application.
occured -> occurred
MainWindow derives from QMainWindow, so we can use tr() directly without the qualification.
This is text that should be translated, since it'll show up as English for non-English speakers.
|
LGTM, but let's wait with merging until after the next beta build is out (assuming we are going to do a beta build this month like I heard plans about). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A few tweaks to the existing strings to make them a little more consistent