Revert "DolphinQt: Minor consistency fixes for the Settings window" #10073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9d45bac.
|
Just to confirm, should I resubmit it sometime soon or you'll take care of that after the next beta build? |
|
I was planning to take care of it. Though if I notice that you've opened a PR for it before I've had time to open my PR, then we'll go with that PR. |
|
I think I'll leave to you then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR #10025 changes a lot of translatable strings and is thus not appropriate to merge right before tagging a beta build. For that reason, I would like to temporarily revert it until this month's beta build has been released.