MMU: Tidy up PTE-related code #10074
Merged
+138
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeps the register definitions in one spot and lets us remove a comment about them.
These are trivial to resolve. Converting the structure member into a u32 results in no increase in structure size, as it's making use of the three extra padding bits in the structure.
Puts the invalidation logic in one place and lets us tidy up InvalidateTLBEntry a little.
Lets us simplify SDRUpdated() a little bit. This also fixes the layout of UReg_SDR1. Turns out this struct has been incorrect (from a little-endian perspective) the entire time and went unnoticed, since the union was never used.
Will be used in the following commit.
Allows us to get rid of a bit of masking in exchange for stating the bits being accessed or written to directly.
JosJuice
reviewed
Aug 31, 2021
JosJuice
reviewed
Aug 31, 2021
JosJuice
reviewed
Aug 31, 2021
Now that we're using register unions where applicable, we can remove these defines, since they're now unused.
PTEs are only ever operated on in terms of their halves in our code currently, so this can be removed.
JosJuice
approved these changes
Aug 31, 2021
leoetlino
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, 2 of 2 files at r4, 2 of 2 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lioncash)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This moves the split PTE definition unions into Gekko.h and eliminates the need for several macro definitions in the MMU code, since we can use the register unions to access the relevant info.
This also fixes the layout of the SDR1 union, which has been incorrect (from a little-endian POV) since it was introduced.
Each commit should be fairly self-isolated for review