Consolidate TexUnit addressing #10096
Merged
+229
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
phire
force-pushed
the
consolidate_tex_unit_addressing
branch
from
9c4debf
to
4ef9f69
Compare
BhaaLseN
reviewed
Sep 12, 2021
Pokechu22
requested changes
Sep 12, 2021
phire
force-pushed
the
consolidate_tex_unit_addressing
branch
from
254bc8c
to
0c47a2f
Compare
Pokechu22
reviewed
Oct 9, 2021
The addressing of the texture units is a bit non-obvious. This struct abstracts the complexity away.
phire
force-pushed
the
consolidate_tex_unit_addressing
branch
2 times, most recently
from
00a0409
to
9519ede
Compare
Pokechu22
reviewed
Oct 9, 2021
Currently the logic for addressing the individual TexUnits is splattered all across dolphin's codebase, this commit attempts to consolidate it all into a single place and formalise it using our new TexUnitAddress struct.
phire
force-pushed
the
consolidate_tex_unit_addressing
branch
from
9519ede
to
9fa2662
Compare
Pokechu22
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
These commits have been split off from #8350, where it was requested in code review.
Currently the logic for addressing the individual TexUnits is splattered all across dolphin's codebase
This PR attempts to consolidate it all into a single place and formalise it.