JitArm64: Fix fresx/frsqrtex unlocking W0 too early #10097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpr.RW may clobber GPRs that are not locked. Fixes https://bugs.dolphin-emu.org/issues/12656.
If W0 is locked when fpr.RW is called, the indirectly called ConvertSingleToDoubleLower may need to emit a push+pop, so it's better for fresx/frsqrtex to call RW before locking W0 than after.
|
Also fixes https://bugs.dolphin-emu.org/issues/12665, apparently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
fpr.RWmay clobber GPRs that are not locked. Fixes https://bugs.dolphin-emu.org/issues/12656.