Common/FileUtil: Strip trailing path separator in ScanDirectoryTree(). #10098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
scan-dir-tree-trailing-slash
branch
from
e7165c7
to
264d4af
Compare
|
Someone should check the behavior on Linux and Android too, I only tested Windows. |
JosJuice
reviewed
Sep 14, 2021
AdmiralCurtiss
force-pushed
the
scan-dir-tree-trailing-slash
branch
from
264d4af
to
f76aaf6
Compare
leoetlino
approved these changes
Sep 20, 2021
|
This has fixed an issue I was having on Linux with the dynamic input textures feature not detecting a gameid.txt within the input textures folder. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Noticed this during debugging. This causes an inconsistency between the path returned in the 'root' directory node and the path returned in all child directory nodes.
Before:
Note how the
rootEntry.physicalNameends in a trailing slash but all child directories do not, and how all child names have a//afterfiles.After:
I hope no one is relying on this behavoir somewhere...