DiscIO/DirectoryBlob: Handle reads between files. #10099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If someone passes an offset past the end of a file but before the start of another file to
DiscContentContainer::Read(), thePadToAddress()call completely fills the buffer with zeroes and reduces the length to 0, but the code flow then tries to callit->Read()anyway, triggering a debug assert about an out-of-bounds offset.To easily observe this just launch an extracted game in a Debug build, the read from
VolumeDisc::IsNKit()is between files in our built disc layout.