GLInterface: Remove unneeded wglShareLists call #10100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When RenderDoc is attached, wglShareLists fails for some reason (see baldurk/renderdoc#2361). wglCreateContextAttribsARB has a parameter for the share context, so there's no reason to use a separate wglShareLists call. Co-authored-by: baldurk <baldurk@baldurk.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When RenderDoc is attached,
wglShareListsfails for some reason (see baldurk/renderdoc#2361).wglCreateContextAttribsARBhas a parameter for the share context, so there's no reason to use a separatewglShareListscall.Note that using OpenGL in Dolphin with RenderDoc still has a separate issue with this patch where the screen appears black initially. This has been fixed on RenderDoc's side, but it seems to be possible to work around it by starting a game/fifolog, then closing it, then starting it again.
This patch is from baldurk/renderdoc#2361 (comment).