NetPlayClient: Split out OnData() into smaller functions #10102
Merged
+980
−821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over time OnData() has become a huge function-long case statement that attempts to manage numerous packet-related behaviors, which makes it a little difficult to reliably ensure certain handling doesn't interfere with another case's. It's also mildly annoying to navigate due to its size. To make it a little easier to read and find the specific behavior, we can break the relevant pieces of code out into their own functions.
In all usage cases, the return value isn't utilized.
leoetlino
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lioncash)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Over time OnData() has become a huge function-long case statement that attempts to manage numerous packet-related behaviors, which makes it a little difficult to reliably ensure certain handling doesn't interfere with another case's. It's also mildly annoying to navigate due to its size.
To make it a little easier to read and find specific behavior, we can break the relevant pieces of code out into their own functions.
Almost all of this change is just code motion