Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheats Manager UX improvements. #10104

Merged
merged 5 commits into from Sep 20, 2021

Conversation

AdmiralCurtiss
Copy link
Contributor

Fixes some annoyances pointed out by @Dentomologist back in #9886.

Specifically:

  • The Cheats Manager option is no longer mysteriously greyed out if no game is running or if cheats are disabled and is instead always active.
  • If no game is running the code tabs are greyed out instead of completely missing.
  • If cheats are disabled and the "Warning: Cheats are disabled! [Configure Dolphin]" header thing shows (as the equivalent tabs in the game properties), the button now actually works -- it didn't before. Granted, it was rather hard to even reach this window in that situation (you'd have to start a game, open the window, close the game, then disable cheats without closing the window), but either way, it works correctly now.
  • This also now allows running memory searches even if cheats are disabled, which is just a nice convenience thing.

Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, untested.

@leoetlino leoetlino merged commit 29d2360 into dolphin-emu:master Sep 20, 2021
10 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the cheats-manager-ux branch September 20, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants