Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StickWidget: Inscribe stick circle within a square #10116

Merged
merged 1 commit into from Sep 20, 2021

Conversation

malleoz
Copy link
Contributor

@malleoz malleoz commented Sep 20, 2021

This PR creates a light gray box around ellipses in the StickWidget. This mimics the old GUI and is useful as it allows TASers to identify the edges of the interactive stick area when clicking outside of the circle.

5.0
image

5.0-15224
image

This PR
image

@JosJuice
Copy link
Member

Your solution for the alignment feels like a bit of a hack. Keep in mind that Dolphin is translated into many languages, some of which may have significantly longer (or shorter) strings than English. The proper solution would be to use something like a QGridLayout, but I suppose that's not the easiest thing to do with how CreateSliderValuePairLayout is structured... Should we maybe not have a CreateSliderValuePairLayout function that creates a layout for just one row? Either way, I think this question is complex enough that this matter should be split out into a different PR, so that the ellipse/square commit can get merged faster.

Please also remove the merge commit from this PR.

Previously, it was not clear where the boundary of the StickWidget was when interacting outside of the circle. This aims to restore the gray square present in the Wx-era.
@JosJuice
Copy link
Member

Okay, second commit removed from the PR. You should update the title of the PR to match the new scope of the PR, though.

The change that this PR makes looks a little strange visually (maybe a black border around it all would help?), but the reasoning behind it makes sense, and the code is fine.

@JMC47, what do you think about the visuals?

@malleoz malleoz changed the title Tas input gui changes StickWidget: Inscribe stick circle within a square Sep 20, 2021
@JMC47
Copy link
Contributor

JMC47 commented Sep 20, 2021

Having the gray box around the joysticks; they don't care as much about the shell of the controller unless they're trying to test the viability of console strats. I think this is a good change.

@JMC47 JMC47 merged commit 7ec02ee into dolphin-emu:master Sep 20, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants