NetPlayProto: Remove lots of casts to MessageId when inserting enum values into packets #10118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be used in future changes to eliminate the need to cast when inserting various message IDs
Now we can leverage our helper to insert enum values without the need to cast.
Continues the migration off the MessageId type alias
Now that we have enum helpers for inserting values into packets and have migrated all other enumerations over, there's no need to keep this alias around any longer.
JosJuice
reviewed
Sep 22, 2021
Now that we have the enum helpers in place, quite a few casts on their own can be removed.
JosJuice
reviewed
Sep 22, 2021
leoetlino
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lioncash)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
MessageIdis kind of used as a wildcard type to insert identifiers into packets. Ideally, sf::Packet would just automatically handle attempted insertions of enum types by converting given identifiers into their underlying primitive type and then insert their values into the packet. This would get rid of the need to have theMessageIdtype alias and allow enums to be self-describing in terms of how they'll be stored.Unfortunately
sf::Packetdoesn't handle enum values out-of-the-box, so we can make our own wrappers to make working with them a little more convenient and also a little bit less verbose