HotkeyScheduler: Check for certain hotkeys in game list #10122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may want to consider putting the PR description into the commit itself, so the context of why the change was made is included in the repository as well, once merged |
malleoz
force-pushed
the
record-hotkeys-without-game-running
branch
2 times, most recently
from
dc6eb47
to
8fc0135
Compare
Done. Will keep this in mind for the future. I didn't consider that the PR notes will not be easily visible once merged. Thanks! |
JosJuice
reviewed
Sep 23, 2021
There are certain hotkeys that we absolutely want to be able to use without being in-game. Presently, no hotkeys are recognized unless we are in-game. I've identified and moved the following hotkeys to be checked before the HotkeyScheduler checks to see if the Core is running: - Open - Exit - Start Recording - Refresh Game List Note that Play Recording should also be implemented here, however it looks like there is no signal for a PlayRecording() function, so this will have to be handled in a later PR once that signal is created and implemented.
malleoz
force-pushed
the
record-hotkeys-without-game-running
branch
from
8fc0135
to
e5051c5
Compare
|
@leoetlino Would |
|
No, that does nothing when no game is running |
JosJuice
approved these changes
Sep 23, 2021
lioncash
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There are certain hotkeys that we absolutely want to be able to use without being in-game. Presently, no hotkeys are recognized unless we are in-game.
I've identified and moved the following hotkeys to be checked before the HotkeyScheduler checks to see if the Core is running:
Note that Play Recording should also be implemented here, however it looks like there is no signal for a PlayRecording() function, so this will have to be handled in a later PR once that signal is created and implemented.