Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotkeyScheduler: add PlayRecording hotkey support #10124

Merged
merged 1 commit into from Sep 29, 2021

Conversation

malleoz
Copy link
Contributor

@malleoz malleoz commented Sep 24, 2021

This hotkey was not previously implemented in the scheduler, even though it's present in the hotkey menu.

This hotkey was not previously implemented in the scheduler, even though it's present in the hotkey menu.
@malleoz malleoz force-pushed the play-recording-hotkey-support branch from 5c5076e to d5845ff Compare September 24, 2021 15:58
@malleoz
Copy link
Contributor Author

malleoz commented Sep 24, 2021

I found there was unintended behavior when pressing Play Recording while a game was already running. Given that this was already not possible in previous dev versions (and quite frankly I don't see why it would be of much help), I have chosen to not recognize the hotkey if a game is running.

I've also identified a further hotkey issue, where hotkeys only work in the games list if "Hotkeys Require Window Focus" is disabled. A future PR should handle this, as it's a bit out of scope of the problem this PR aimed to solve.

Correction: Looks like this is all working as intended.

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@JosJuice JosJuice merged commit c84c1ac into dolphin-emu:master Sep 29, 2021
10 checks passed
@malleoz malleoz deleted the play-recording-hotkey-support branch October 13, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants