Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QFileDialog: differentiate between recording open/save #10129

Merged
merged 1 commit into from
Sep 29, 2021
Merged

QFileDialog: differentiate between recording open/save #10129

merged 1 commit into from
Sep 29, 2021

Conversation

malleoz
Copy link
Contributor

@malleoz malleoz commented Sep 27, 2021

Previously, the file dialog window was ambiguous between saving or loading a .dtm. This commit simply gives a bit more context to differentiate the two windows.

Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (other than the lint failure)

Previously, the file dialog window was ambiguous between saving or loading a .dtm. This commit simply gives a bit more context to differentiate the two windows.
@phire phire merged commit bb36739 into dolphin-emu:master Sep 29, 2021
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@malleoz malleoz deleted the recording-save-playback-window branch September 29, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants