IOWindow: Do not accept on syntax errors #10131
Merged
+6
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In the current Dolphin dev, typing anything into a hotkey formula box and clicking OK would prompt you with a syntax error window, only for your gibberish to be accepted as input. After closing out of the error window, your change would be applied and the formula window would close.
This PR fixes two issues, the latter of which is only exposed when the former is fixed.
Before:
https://i.imgur.com/SgWm6AW.mp4
After:
https://i.imgur.com/lcHY8fK.mp4