New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AbortOnPanicAlert with PanicAlertFmt #10138
Fix AbortOnPanicAlert with PanicAlertFmt #10138
Conversation
|
dolphin/Source/Core/VideoCommon/CPMemory.h Lines 108 to 124 in a7224b2
The normal format and the format of both colors is set to 5, which is invalid (the other components are set to 4, indicating float). |
|
Do you want to fix the FIFO_CI failures before merging this? |
|
I don't think they have an easy fix, so I'm fine with leaving them erroring for now until I have time to research them further. |
2b52c96
to
bad2217
Compare
Source/Core/Common/MsgHandler.cpp
Outdated
|
|
||
| return true; | ||
| return ShowMessageAlert(caption, message.c_str(), yes_no, style); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of message.c_str() means the previous string_view change doesn't do anything. Will replace with just message.
bad2217
to
73d0758
Compare
PR dolphin-emu#10066 added functionality to call std::abort when a panic alert occurs; however, that PR only implemented it for MsgAlert and not MsgAlertFmtImpl, meaning that the functionality was not used with PanicAlertFmt (only PanicAlert, which is not used frequently).
73d0758
to
ec9db32
Compare
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
PR #10066 added functionality to call std::abort when a panic alert occurs; however, that PR only implemented it for
MsgAlertand notMsgAlertFmtImpl, meaning that the functionality was not used withPanicAlertFmt(onlyPanicAlert, which is not used frequently).