Import Apple/FFmpeg libraries for AVI dumps on macOS #10145
Merged
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you squash the commits please? |
Imports Apple libraries and also pulls swresample in, so when compiling Dolphin doesn't throw undefined symbols.
OatmealDome
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When attempting to compile
DolphinwithFFmpegI noticed a bunch of undefined symbol errors, so I looked into it more and as a band-aid fix I modified the./CMakeLists.txtand./Source/Core/VideoCommon/CMakeLists.txtfiles to add libraries that resolve the errors.These libraries are:
It should also be noted that I used
FFmpeg v4.4with configure flags--disable-asm --disable-docs --disable-securetransportwithDolphin. I tried to add theSecurityframework but the undefined symbol wasn't resolved. As a band-aid fix, I used--disable-securetransport. Asm & docs are disabled as docs takes time to compile & asm throws a bunch of freestanding warnings when compiling withDolphin.