Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt/Android: Add warning when converting NKit files #10146

Merged
merged 1 commit into from Oct 3, 2021

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Oct 2, 2021

Yes, that's right! It's time to add even more NKit warnings, because users still don't understand what NKit is or how it works!

More specifically, some users seem to be under the impression that converting an NKit file to for instance RVZ using Dolphin's convert feature will result in a normal RVZ file, when it in fact results in an NKit RVZ file (since NKit is not a container format in the sense that GCZ/WIA/RVZ/WBFS/CISO is, but rather a kind of trimmed ISO). I can hardly blame users for not knowing this, because it's not intuitive unless you know the technical details of how NKit works.

Yes, that's right! It's time to add even more NKit warnings,
because users still don't understand what NKit is or how it works!

More specifically, some users seem to be under the impression that
converting an NKit file to for instance RVZ using Dolphin's convert
feature will result in a normal RVZ file, when it in fact results in
an NKit RVZ file (since NKit is not a container format in the sense
that GCZ/WIA/RVZ/WBFS/CISO is, but rather a kind of trimmed ISO).
I can hardly blame users for not knowing this, because it's not
intuitive unless you know the technical details of how NKit works.
@Rumi-Larry
Copy link

Why not just completely disable this conversion?

@JosJuice
Copy link
Member Author

JosJuice commented Oct 2, 2021

It does have a purpose if you have .nkit.iso and you want to convert it to something that is still NKit but takes up less space, like .nkit.gcz (which by the way is something that's explicitly supported in the NKit app). Not that I know why people would want to convert to something which still is NKit, but well, I don't think people should use NKit in general either and yet they do it :)

I suppose another reason is that I don't entirely like arbitrary limitations in Dolphin's functionality. An .nkit.iso file is in fact just an ISO file, and Dolphin is supposed to be able to convert ISO files. So far, everything I've done in Dolphin in regards to NKit has only been to add various kinds of warnings, not to change how Dolphin actually behaves. Though, this is a rather weak argument, I must admit.

tr("Dolphin can't convert NKit files to non-NKit files. Converting an NKit file in "
"Dolphin will result in another NKit file.\n"
"\n"
"If you want to convert an NKit file to a non-NKit file, you can use the same "
"program as you originally used when converting the file to the NKit format.\n"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest the following wording:

Suggested change
tr("Dolphin can't convert NKit files to non-NKit files. Converting an NKit file in "
"Dolphin will result in another NKit file.\n"
"\n"
"If you want to convert an NKit file to a non-NKit file, you can use the same "
"program as you originally used when converting the file to the NKit format.\n"
tr("Dolphin cannot properly convert an NKit file to another file format."
"Trying to, will convert it to a hybrid between NKit and the target format,"
"that may not behave as expected.\n"
"\n"
"If you want to do a proper conversion, please use another program.\n"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dolphin cannot properly convert an NKit file to another file format

It can properly convert an NKit file in one container format to an NKit file in another container format.

Trying to, will convert it to a hybrid between NKit and the target format

Combining NKit with a compressed container format is not some kind of strange hybrid. .nkit.gcz is the default output of the NKit app.

that may not behave as expected

I'd rather be clear about in what way it doesn't behave as expected, since it's simple to explain: The file will still be an NKit file. The problems you will have are the exact same as with any other NKit file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very complicated stuff, in which case I cannot think of a better wording than the one you are using. Still, it doesn't read particularly well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that said, I'm willing to drop the second paragraph if there's more than one person who doesn't think we should include what I wrote there. (I would prefer dropping it over going with your variant, since your variant doesn't really provide any information that isn't already implied by the first paragraph.)

@Rumi-Larry
Copy link

It does have a purpose if you have .nkit.iso and you want to convert it to something that is still NKit but takes up less space, like .nkit.gcz (which by the way is something that's explicitly supported in the NKit app). Not that I know why people would want to convert to something which still is NKit, but well, I don't think people should use NKit in general either and yet they do it :)

I suppose another reason is that I don't entirely like arbitrary limitations in Dolphin's functionality. An .nkit.iso file is in fact just an ISO file, and Dolphin is supposed to be able to convert ISO files. So far, everything I've done in Dolphin in regards to NKit has only been to add various kinds of warnings, not to change how Dolphin actually behaves. Though, this is a rather weak argument, I must admit.

How difficult would it be to make it possible to do proper conversion of NKit files within Dolphin? It seems like the users really want NKit files no matter the cost.

@JosJuice
Copy link
Member Author

JosJuice commented Oct 2, 2021

Much harder than the formats we already support. I'm not willing to implement it myself.

To be frank here, the only people who use NKit files and don't already know how to use the NKit app are pirates. Even if it wasn't for the NKit format being as complicated as it is, I'm not going to implement features that only benefit pirates (apart from the feature of Dolphin yelling at them so that they don't come asking us for support with problems caused by the poor decisions of warez sites).

@leoetlino leoetlino merged commit 33ffc7a into dolphin-emu:master Oct 3, 2021
10 checks passed
@JosJuice JosJuice deleted the nkit-convert-warning branch October 3, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants