GameINI: Update Cheats for GMPE01, GP5E01, GP6E01, GP7E01 #10147
Conversation
|
Please spell out Mario Party. I checked this PR expecting to find Metroid Prime cheats and was very disappointed... |
|
Yeah, please put "GameINI: " in the commit message and write out Mario Party to make the commit title clearer. |
|
I suggest the title: "GameINI: Add more cheats as well as restore proper credit of them for some Mario Party games" |
|
That is very long, though. "Add more cheats as well as restore proper credit of them" would be appropriate to shorten to "Update cheats". |
EndangeredNayla
changed the title
|
Since when do we include user cheats within Dolphin? I must have missed when this changed. |
|
What do you mean? |
I was under the impression Data/Sys/GameSettings inis were only for Dolphin related fix/patches. User/GameSettings (user external added) would have cheats unrelated to Dolphin issues (aka not in the source) Was this changed or was it always like this? What determines if cheats can be included within Dolphin Source? This is not necessarily a question to you if you don't know- but the Dolphin repo maintainers. |
|
It's been like this for at least 7 years and probably even longer. (I joined the project 7 years ago.) I don't think we have any proper criteria for which cheats should be included, though. |
|
Could we merge this soon? |
Data/Sys/GameSettings/GP7E01.ini
Outdated
| 7C000214 48000008 | ||
| 38000063 98030005 | ||
| 60000000 00000000 | ||
| *50 turns becomes 99 due to interger cap. |
|
Any chance for a merge |
Not a reviewer, but based on my past experience you will need to rebase on master instead of having another merge commit in your PR. PR merges are typically in cycles from what I've seen so if its good to go expect it sometime this week/next week. |
|
This should be fine I think @leoetlino |
No description provided.