DolphinQt: Add i18n comment for "Keep addresses where value in memory" #10148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
reviewed
Oct 3, 2021
|
Maybe combining the label with the dropdown would make it better? But yeah I admit this is not particularly localization-friendly... |
This string is extremely likely to be mistranslated without the proper context. Actually, it's probably impossible to translate this string in a good way to some languages, but I'm not sure how to solve that. Let's at least add an i18 comment for now.
JosJuice
force-pushed
the
i18n-keep-addresses
branch
from
1d26db3
to
8f9086f
Compare
|
I'm not sure if there are any languages we support where that actually would help. My main concern is with languages where the verb comes at the end of the sentence. |
leoetlino
approved these changes
Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This string is extremely likely to be mistranslated without the proper context. Actually, it's probably impossible to translate this string in a good way to some languages, but I'm not sure how to solve that. Let's at least add an i18 comment for now.