Add Game ID, timecode to dspdump and dtkdump filenames #10149
Merged
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malleoz
force-pushed
the
audiodump-add-timecode
branch
from
7876f59
to
f4371a8
Compare
lioncash
reviewed
Oct 3, 2021
malleoz
force-pushed
the
audiodump-add-timecode
branch
from
f4371a8
to
febff6c
Compare
Match the same formatting present in framedump filenames.
malleoz
force-pushed
the
audiodump-add-timecode
branch
from
febff6c
to
1d5d896
Compare
leoetlino
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Framedump filenames store the game ID and timecode to represent when the file was created. I felt that this should be consistent with audiodumps too, so I have added identical formatting for the dspdump and dtkdump filenames.
Only issue I can see here is that the timecode may not match the framedump. It looks like the audiodump files are created before the framedump files. Does it matter if the timecodes don't line up? Perhaps not, as it will still be easy to identify what the corresponding video/audio files are for a session.