update mgba submodule #10150
Merged
update mgba submodule #10150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIK mgba won't be breaking compatibility without breaking API, so just compiling should be enough. It would be nice to at least see if games still boot tho |
|
Tested this to make sure the Integrated GBA worked, and it does. Connected and played Four Swords no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
this should allow msvc to compile all C code in dolphin+Externals with
/stdc17, however I'm not sure it's really useful, since majority of C code is in Externals, where we disable compiler warnings. (and we may not want to specify the language standard for Externals, anyway).I have only checked it compiles , would be nice if someone else could chime in with if it's OK to just grab mgba HEAD like this.