New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Add IDA Save/Load Dolphin Map Scripts for 7.x #10157
Conversation
|
I might be wrong but AFAIK the convention of this repository is to not change the copyright year of existing files... |
All I could find is Which does not specify this. If someone can confirm I'll change the 6.x scripts, though they were modified/changed with the extra check. |
|
It is our policy that the copyright year is based on when the file was created, not when it was last modified. Though indeed, I don't think I can see any place where this policy is written down other than review comments on PRs. |
|
It's mentioned at #1826 (comment) and #7786 (comment) for instance. |
|
Theoretically it could be updated if the file has substantially changed, but you have only made minor changes to those files here. |
Gotcha, will update.
For clarity sake, since the original files were moved those should stay as 2018. I'm just opting to set them all to 2018 because the changes are minor, even to the 7.x change. If it was a refactor/written from scratch I think 2021 would be justified. Re-pushed with 2018 on all. |
14d8c54
to
82b5ba6
Compare
|
@dolphin-emu-bot rebuild |
I would've set them to 2021, but I don't think it really matters. It's a bit arbitrary. Let's leave it as it is unless someone else objects. |
|
New files should be 2021. |
82b5ba6
to
d99664a
Compare
Changed the 7.x files to 2021, per objection. pushed. |
|
Looks Tools/ was missed in #9862. The license comments should be SPDX tags, no? |
|
Yes, ideally. But since it was missed in that PR, I'm fine with leaving it as it is in this PR, so as to not put a bunch of unrelated changes in the same PR. |
IDA 7.4+ breaks compatibility with IDA 6.x style scripts.
All IDA 7.0+ versions are compatible with IDA 7.x style scripts.
Updated unsupported calls per official hex-rays document:
https://hex-rays.com/products/ida/support/ida74_idapython_no_bc695_porting_guide.shtml