Core: Use log variant of PrintCallstack, not print variant #10159
+1
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two reasons for this. 1. Using Dolphin's logging system lets the user decide whether the printout should go to the terminal, the GUI, or a file. fmt::print always prints to stdout... unless you're on Android, in which case it does nothing at all, because Android disables stdout. 2. The Windows version of Dolphin crashes when you use fmt::print. Yes, really. The crash happens because a call to std::fprint in fmt::v7::detail::fwrite_fully returns that less characters were written than requested, which fmt handles by throwing an exception. (As always, Dolphin does not use exception handling.) I'm not sure why std::fprint is doing this, but since switching away from using fmt::print is a good idea due to the previous point anyway, I'd say it's best to just switch.
|
Can confirm that this PR fixes the crash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There are two reasons for this.
Using Dolphin's logging system lets the user decide whether the printout should go to the terminal, the GUI, or a file.
fmt::printalways prints to stdout... unless you're on Android, in which case it does nothing at all, because Android disables stdout.The Windows version of Dolphin crashes when you use
fmt::print. Yes, really. The crash happens because a call tostd::fprintinfmt::v7::detail::fwrite_fullyreturns that less characters were written than requested, which fmt handles by throwing an exception. (As always, Dolphin does not use exception handling.) I'm not sure whystd::fprintis doing this, but since switching away from usingfmt::printis a good idea due to the previous point anyway, I'd say it's best to just switch.