JitArm64: Implement memcheck #10162
Merged
JitArm64: Implement memcheck #10162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
jitarm64-memcheck
branch
from
e67392c
to
7f761da
Compare
degasus
reviewed
Oct 20, 2021
| in_far_code = true; | ||
| SwitchToFarCode(); | ||
| fastmem_area->slowmem_code = GetCodePtr(); | ||
| m_handler_to_loc[handler] = GetCodePtr(); |
There was a problem hiding this comment.
You could save a few lines of code here by using if (!jo.memcheck) m_handler_to_loc[handler] = GetCodePtr();, however this would perform an empty map lookup. No clue which one is better...
There was a problem hiding this comment.
Hmm... I was thinking that the "A reusable slowmem handler was found" case would also need to be guarded by a jo.memcheck check. I suppose that that isn't actually necessary, because there is no code that is adding elements to m_handler_to_loc when we have jo.memcheck, but it feels like something that would be confusing to a first-time reader of the code. So I think I'd like to do it the way it currently is.
You can now specify an already allocated register for it to use as a temporary register, and it also supports being called while in farcode.
Fixes a problem introduced in the previous commit.
If a host register has been newly allocated for the destination guest register, and the load triggers an exception, we must make sure to not write the old value in the host register into ppcState. This commit achieves this by not marking the register as dirty until after the load is done.
Being able to preserve the address register is useful for the next commit, and W0 is the address register used for loads. Saving the address register used for stores, W1, was already supported.
Small optimization. If the caller already has an FPR that it isn't using, might as well pass it on to fpr.Flush.
JosJuice
force-pushed
the
jitarm64-memcheck
branch
from
7f761da
to
5490797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.