JitArm64: Work around a GCC warning promoted to error #10168
Merged
+20
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC complains about float_emit being null when inlining ByteswapAfterLoad into MMIOLoadToReg. ByteswapAfterLoad does dereference float_emit, but only when passing FLAG_FLOAT, which MMIOLoadToReg has an assert for and does not support. Also cleaning up some unnecessarily specified namespaces while I'm at it.
leoetlino
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
GCC complains about float_emit being null when inlining ByteswapAfterLoad into MMIOLoadToReg. ByteswapAfterLoad does dereference float_emit, but only when passing FLAG_FLOAT, which MMIOLoadToReg has an assert for and does not support.
Also cleaning up some unnecessarily specified namespaces while I'm at it.