Android: Allow starting game with Riivolution patches from the GUI #10184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
android-riivolution
branch
from
f6e2476
to
ff58571
Compare
|
Tested on ASUS ROG Phone 2, Riivolution patches are working properly. Only the configuration GUI is missing as mentioned in the TODO list.
|
JosJuice
force-pushed
the
android-riivolution
branch
from
ff58571
to
eb46410
Compare
|
Configuration GUI added. It's not super pretty, but it works. (Remember when we had a contributor who actually had experience in Android UI/design? Ah, those were times...)
|
JosJuice
force-pushed
the
android-riivolution
branch
3 times, most recently
from
6c1bbaa
to
686301e
Compare
|
I added one more thing: The SD root path is now shown, so that you know where you can place your files. In particular, I wanted to add this so that the activity wouldn't just be completely empty other than the Start button when you have no patches. Using SAF to select a different SD root would kill the emulation performance, so I'm not adding that as a feature.
|
sepalani
suggested changes
Oct 30, 2021
.../app/src/main/java/org/dolphinemu/dolphinemu/features/riivolution/ui/RiivolutionAdapter.java
Outdated
Show resolved
Hide resolved
...oid/app/src/main/java/org/dolphinemu/dolphinemu/features/riivolution/ui/RiivolutionItem.java
Outdated
Show resolved
Hide resolved
JosJuice
force-pushed
the
android-riivolution
branch
from
686301e
to
8b0624f
Compare
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
1 similar comment
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
sepalani
approved these changes
Oct 31, 2021
There was a problem hiding this comment.
SGTM.
The configuration UI works even when there are many options. I can scroll the list without issues to reach the other options.
Options screenshot
I tested it with NewerSMB, Ultimate MH3 and Wii Sport Resort Storm Island and the configuration UI is working fine. (However, Wii Sport doesn't boot, see #10194)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
TODO: