New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for GameModDescriptor files in Game List. #10187
Conversation
3a99a93
to
b454309
Compare
|
If you add dolphin/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/FileBrowserHelper.java Line 33 in ffdc853
(Well, work barring scoped storage... But this would be kind of a power user feature anyway, at least on Android.) |
b8d79cb
to
18b730d
Compare
65b31d0
to
cbd3b43
Compare
cbd3b43
to
4824a3d
Compare
|
Tested. Launches correctly from Gamelist and Netplay. |
a56fba4
to
7b7c39d
Compare
7b7c39d
to
56c7d45
Compare
|
Like with the original Riivolution PR: I would appreciate if @leoetlino could look at the save redirection part, but the rest LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, just one minor complaint.
56c7d45
to
b928900
Compare
|
Is there a way to set the Maker in addition to the name and banner? |
|
An HBC-style XML file works, but I feel like it'd make sense to have a field in the JSON. |
|
Yeah we can probably add that, should be easy enough. |
Someone more familiar with how the game list cache works please check if this is correct.
TODO: