Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GameModDescriptor files in Game List. #10187

Merged
merged 8 commits into from Dec 14, 2021

Conversation

AdmiralCurtiss
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss commented Oct 26, 2021

Someone more familiar with how the game list cache works please check if this is correct.

TODO:

  • Sensible Netplay hash calculation.
  • The temporary Netplay NAND interacts very poorly with savegame redirection.

@AdmiralCurtiss AdmiralCurtiss force-pushed the json-gamelist branch 2 times, most recently from 3a99a93 to b454309 Compare October 26, 2021 01:41
@JosJuice
Copy link
Member

If you add json here, your feature will probably work in the Android game list without any further changes:

"gcm", "tgc", "iso", "ciso", "gcz", "wbfs", "wia", "rvz", "wad", "dol", "elf"));

(Well, work barring scoped storage... But this would be kind of a power user feature anyway, at least on Android.)

@AdmiralCurtiss AdmiralCurtiss force-pushed the json-gamelist branch 2 times, most recently from b8d79cb to 18b730d Compare October 31, 2021 05:10
@AdmiralCurtiss AdmiralCurtiss force-pushed the json-gamelist branch 2 times, most recently from 65b31d0 to cbd3b43 Compare November 14, 2021 01:45
@AdmiralCurtiss AdmiralCurtiss marked this pull request as ready for review November 23, 2021 21:58
@JMC47
Copy link
Contributor

JMC47 commented Dec 3, 2021

Tested. Launches correctly from Gamelist and Netplay.

Source/Core/DiscIO/Blob.cpp Outdated Show resolved Hide resolved
Source/Core/UICommon/GameFile.cpp Outdated Show resolved Hide resolved
Source/Core/UICommon/GameFile.cpp Outdated Show resolved Hide resolved
Source/Core/Core/NetPlayCommon.cpp Show resolved Hide resolved
@AdmiralCurtiss AdmiralCurtiss force-pushed the json-gamelist branch 3 times, most recently from a56fba4 to 7b7c39d Compare December 8, 2021 23:03
@JosJuice
Copy link
Member

Like with the original Riivolution PR: I would appreciate if @leoetlino could look at the save redirection part, but the rest LGTM.

@leoetlino leoetlino self-requested a review December 12, 2021 21:38
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just one minor complaint.

Source/Core/Core/WiiRoot.cpp Outdated Show resolved Hide resolved
@leoetlino leoetlino merged commit 185475f into dolphin-emu:master Dec 14, 2021
9 of 10 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the json-gamelist branch December 14, 2021 10:11
@leo60228
Copy link

leo60228 commented Jan 2, 2022

Is there a way to set the Maker in addition to the name and banner?

@leo60228
Copy link

leo60228 commented Jan 2, 2022

An HBC-style XML file works, but I feel like it'd make sense to have a field in the JSON.

@AdmiralCurtiss
Copy link
Contributor Author

Yeah we can probably add that, should be easy enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants