Externals: Update imgui to 1.85 #10188
Conversation
| if (m_scroll_to_bottom) | ||
| { | ||
| ImGui::SetScrollHere(1.0f); | ||
| ImGui::SetScrollHereY(1.0f); | ||
| m_scroll_to_bottom = false; | ||
| } |
There was a problem hiding this comment.
SetScrollHere was marked as obsolete in v1.66 and removed in v1.82.
| @@ -978,6 +978,7 @@ bool Renderer::InitializeImGui() | |||
| ImGui::GetIO().DisplayFramebufferScale.y = m_backbuffer_scale; | |||
| ImGui::GetIO().FontGlobalScale = m_backbuffer_scale; | |||
| ImGui::GetStyle().ScaleAllSizes(m_backbuffer_scale); | |||
| ImGui::GetStyle().WindowRounding = 7.0f; | |||
There was a problem hiding this comment.
The default value was changed to 0.0f in v1.80; 7.0f was the previous default. See ocornut/imgui@b015ea9.
| const float center_x = ImGui::GetIO().DisplaySize.x * 0.5f; | ||
| const float center_y = ImGui::GetIO().DisplaySize.y * 0.5f; | ||
| const float scale = ImGui::GetIO().DisplayFramebufferScale.x; | ||
|
|
||
| ImGui::SetNextWindowSize(ImVec2(400.0f * scale, 50.0f * scale), ImGuiCond_Always); | ||
| ImGui::SetNextWindowPosCenter(ImGuiCond_Always); | ||
| ImGui::SetNextWindowPos(ImVec2(center_x, center_y), ImGuiCond_Always, ImVec2(0.5f, 0.5f)); |
There was a problem hiding this comment.
SetWindowPosCenter was marked as obsolete in v1.52 and removed in v1.74.
|
This is causing an error window when going in and out of fullscreen. |
|
Yeah I'm mean just using build 5.0-15419 right before this was merged the issue is not present. |
|
That issue has been fixed in 5.0-15427 since a clean build was performed for that. Technically, this PR didn't cause the issue (everything would work properly if you built it locally), but instead the build system not rebuilding files that depended on imgui caused it. That's still something that should be fixed, but it's not clear exactly why the build system isn't rebuilding it. |
|
I see. Ok then. |
This PR updates Dear ImGui to v1.85 (from 1.70). There shouldn't be any behavior differences, but this update is useful for some other stuff I'm working on (in particular, it adds
BeginDisabledandEndDisabled, and also causes a scroll bar to show up if a window is too big andImGuiWindowFlags_AlwaysAutoResizeis in use (before, the window would just not render properly)).