Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheats Manager quality of life improvements. #10190

Merged
merged 5 commits into from Oct 29, 2021

Conversation

AdmiralCurtiss
Copy link
Contributor

See https://forums.dolphin-emu.org/Thread-hexadecimal-searches-cheat-manager

  • Geometry of the window is now saved across sessions.
  • There's an extra checkbox to force parsing the input value as hexadecimal even without the 0x prefix.
  • Starting a new search with standard regions when no game is running is disallowed now, as it could lead to incorrect memory regions being used (GC/Wii difference; also starting before the first game boot returned a memory size of 0).

@iwubcode
Copy link
Contributor

Code looked good to me. One comment that I probably missed before, CheatSearchSession could be marked final for a potentially slight perf boost.

Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane

@leoetlino leoetlino merged commit 663b937 into dolphin-emu:master Oct 29, 2021
10 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the cheats-manager-qol branch October 29, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants