Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameINI: Fix Comment Causing Parsing Errors in Mario Party 6/7 INIs. #10201

Merged
merged 1 commit into from Nov 15, 2021

Conversation

JMC47
Copy link
Contributor

@JMC47 JMC47 commented Nov 4, 2021

It appears that this code is a Gecko Code and was mistakenly put as an Action Replay code. I may be wrong and it may be a different problem, but based on the how the code looks I'm confident this was the problem. The code didn't crash the game when I moved it to Gecko, and it was causing problems when it was under Action Replay.

@PatrickFerry
Copy link
Contributor

I think you should do the same for GP7E01.ini

@JMC47
Copy link
Contributor Author

JMC47 commented Nov 4, 2021

GP7E01 isn't complaining as far as I can tell, and I don't know for certain if this is the problem. I'm not an expert. If you know for sure it's wrong, I can move it.

@PatrickFerry
Copy link
Contributor

I just seen that it was the same creator with the same goal in mind.

An obvious issue to me is the asterisk in the comments for the action replay code aren't valid. The comments under action replay codes would have to be using a hash unlike the gecko codes

@JMC47
Copy link
Contributor Author

JMC47 commented Nov 4, 2021

I didn't know that; maybe that's the problem and it is an action replay code?

Using the "*" symbol as a comment only works for Gecko Codes for some
reason.  I changed it to "#".
@JMC47
Copy link
Contributor Author

JMC47 commented Nov 15, 2021

Testing to see if this fixes it properly.

@JMC47 JMC47 changed the title GameINI: Move Mario Party 6 Orb Expansion code to Gecko Code GameINI: Fix Comment Causing Parsing Errors in Mario Party 6/7 INIs. Nov 15, 2021
@JMC47
Copy link
Contributor Author

JMC47 commented Nov 15, 2021

Everything seems to be working on this now.

@leoetlino leoetlino merged commit d17dcf7 into dolphin-emu:master Nov 15, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants