JitArm64: Implement fctiwx #10202
Merged
JitArm64: Implement fctiwx #10202
+40
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We implement this by first rounding to nearest integer using the current rouding mode, then converting this value from floating point to an integral value.
JosJuice
approved these changes
Nov 6, 2021
lioncash
approved these changes
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As a FCVTS instruction that uses the current rounding mode does not exist on ARM64, the easiest way to implement fctiwx would be to first convert to an integral floating point using the native rounding mode, then converting that value to an integer (rounding mode doesn't matter in this second step as result would be exact).
TODO is the same TODO as in the Jit64 backend.
Tested in FZGX.