Android: Increase targetSdkVersion to 31 (Android 12) #10212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase, but LGTM otherwise (haven't tested it) |
Unlike with Android 11, there should be no downsides to doing this, so we might as well get this out of the way early. The main part of the work was already done in 5a1a642.
|
Works fine on the Android emulator on a M1 Mac. Adding a directory and booting something still works.
|
lioncash
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Unlike with Android 11, there should be no downsides to doing this, so we might as well get this out of the way early. The main part of the work was already done in PR #9654.
Do not merge this until it has been tested by someone who has Android 12! I don't have Android 12 myself.