MoltenVK: Don't run fetchDependencies unnecessarily #10214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
leoetlino
reviewed
Nov 14, 2021
OatmealDome
force-pushed
the
mvk-better-incremental
branch
from
fe4866c
to
730df73
Compare
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently, MoltenVK's
fetchDependenciesscript is ran on every build. The script clones various git repositories for dependencies and rebuilds each one of them. This causes rebuild times to take significantly longer, which makes development more annoying. To fix this, don't run the script after the initial build if MoltenVK's version hasn't been updated.Decreases rebuild times without any changes to source code from ~250s to ~10s on an M1 Mac Mini.