Cleanup and Update N64 Virtual Console INIs #10236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
reviewed
Nov 21, 2021
Data/Sys/GameSettings/NAL.ini
Outdated
| # This game crashes very soon after boot if EFB copies are scaled at higher resolutions. | ||
| # This is due to Dolphin running out of memory. Disabling Scaled EFB copies allows playing | ||
| # at higher resolutions without the game crashing for now. | ||
| EFBScaledCopy = True |
There was a problem hiding this comment.
Do you mean False here? The comment and the value don't match I think
There was a problem hiding this comment.
I didn't realize I never pushed this - should be fixed now.
iwubcode
reviewed
Nov 21, 2021
Data/Sys/GameSettings/NAT.ini
Outdated
| # This game crashes very soon after boot if EFB copies are scaled at higher resolutions. | ||
| # This is due to Dolphin running out of memory. Disabling Scaled EFB copies allows playing | ||
| # at higher resolutions without the game crashing for now. | ||
| EFBScaledCopy = True |
This Pull Request updates N64 INIs based on what I know about various behaviors since the last time we updated it. This should result in more sane settings for Mario Tennis and Super Smash Bros. while still preventing the out of memory crash due to the tremendous amounts of EFB copies.
JosJuice
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This Pull Request updates N64 INIs based on what I know about various behaviors since the last time we updated it. This should result in more sane settings for Mario Tennis and Super Smash Bros. while still preventing the out of memory crash due to the tremendous amounts of EFB copies.