Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and Update N64 Virtual Console INIs #10236

Merged
merged 1 commit into from Dec 20, 2021
Merged

Conversation

JMC47
Copy link
Contributor

@JMC47 JMC47 commented Nov 20, 2021

This Pull Request updates N64 INIs based on what I know about various behaviors since the last time we updated it. This should result in more sane settings for Mario Tennis and Super Smash Bros. while still preventing the out of memory crash due to the tremendous amounts of EFB copies.

# This game crashes very soon after boot if EFB copies are scaled at higher resolutions.
# This is due to Dolphin running out of memory. Disabling Scaled EFB copies allows playing
# at higher resolutions without the game crashing for now.
EFBScaledCopy = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean False here? The comment and the value don't match I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize I never pushed this - should be fixed now.

# This game crashes very soon after boot if EFB copies are scaled at higher resolutions.
# This is due to Dolphin running out of memory. Disabling Scaled EFB copies allows playing
# at higher resolutions without the game crashing for now.
EFBScaledCopy = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto my other comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

This Pull Request updates N64 INIs based on what I know about various
behaviors since the last time we updated it.  This should result in more
sane settings for Mario Tennis and Super Smash Bros. while still
preventing the out of memory crash due to the tremendous amounts of EFB
copies.
@JMC47 JMC47 merged commit 1d146a9 into dolphin-emu:master Dec 20, 2021
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants