NetPlayServer: Clear remaining m_players when netplay thread ends so that their destructors can run while the ENetHost still exists. #10237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that their destructors can run while the ENetHost still exists.
AdmiralCurtiss
force-pushed
the
netplay-server-crash
branch
from
97441e5
to
e2c4cf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Otherwise the QoSSession destructor attempts to access the already deleted ENetHost, which appears fairly harmless but is still technically a use-after-free. (and crashes Debug builds, which is how I found it)
e: Oh, to clarify, this is relevant when the host closes the window while some clients are still connected.