GBA: Add import and export save options to context menu. #10240
Merged
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
mgba-save-import-export
branch
from
d76a709
to
8488ff6
Compare
iwubcode
reviewed
Nov 21, 2021
| @@ -229,6 +229,36 @@ void GBAWidget::DoState(bool export_state) | |||
| false); | |||
| } | |||
|
|
|||
| void GBAWidget::ImportExportSave(bool export_save) | |||
There was a problem hiding this comment.
I don't personally have a strong opinion about this but I know some people prefer an enumeration over a boolean
There was a problem hiding this comment.
I just copied the existing DoState() more or less, but yeah, probably.
|
This is probably an improvement. Does this handle that each GBA uses a different save? |
|
It does handle that correctly, yes. |
|
Tested with all 4 GBAs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Since users seem to be very confused about where save files should go for the emulator to pick them up.